Repository navigation
Conversation
bd654df to
8973a3c
Compare
I'm a bit confused. If it hardly stands out, it hardly stands out regardless of whether you perform a search or not? And generally such a problem is just a problem of a particular colorscheme, right? (And BTW can be easily worked around by the user, by copying the colorscheme to the user's |
|
Do those other editors you are using also have an equivalent of your This just seems quite odd to me in terms of user experience: the selection color suddenly changes (e.g. from dark gray to yellow in your example) just because we've searched some text so it got highlighted. EDIT: I take it back, I've just tried your PR and I see it does a different thing than what I thought: the This actually seems quite reasonable to me, and might be useful even regardless of color contrast issues. |
|
|
||
| if highlight { | ||
| if w.Buf.HighlightSearch && w.Buf.SearchMatch(bloc) { | ||
| isHighlightSearchMatch := w.Buf.HighlightSearch && w.Buf.SearchMatch(bloc) |
There was a problem hiding this comment.
nit: just highlightSearchMatch. This boolean is not a characteristic of something (like isActive, isModified, isEol and so on), it is an indication whether to do something. IOW, "is highlight search match" ("is" followed by a verb in the imperative mood) is not grammatically correct, right?
There was a problem hiding this comment.
Good point! The is + verb combination is ungrammatical.
Renamed to highlightSearchMatch.
8973a3c to
055dab4
Compare
| * error-message (Color of error messages in the bottom line of the screen) | ||
| * match-brace (Color of matching brackets when `matchbracestyle` is set to `highlight`) | ||
| * hlsearch (Color of highlighted search results when `hlsearch` is enabled) | ||
| * hlsearch.selection (Color of the selection within highlighted search results when `hlsearch` is enabled) |
There was a problem hiding this comment.
Wrap this line at ~80 characters, in line with the rest of this help doc?
micro allows setting colors for selections and for search results. If a colorscheme defines a selection color that is very similar to the hlsearch highlight color, the currently selected text will hardly stand out during a highlighted search. So add a new color-group analogous to `statusline`, `statusline.inactive`, `statusline.suggestions`.
055dab4 to
4ea2eb2
Compare




micro allows to set the color for selections and for search results. However, if your color scheme defines a color for selections that is very similar to your general background color, and you perform a search, the currently selected text will hardly stand out.
Since this cannot be done with plugins, it would be great if we can add a new color-group analogous to
statusline,statusline.inactive,statusline.suggestions.